Add button to open live chat popup in browser #8278
Conversation
github-actions
bot
added
the
PR: waiting for review
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
src/renderer/components/WatchVideoLiveChat/WatchVideoLiveChat.vue
Outdated
Show resolved
Hide resolved
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Head branch was pushed to by a user without write access
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
…d-live-chat-button-pop-out
Head branch was pushed to by a user without write access
src/renderer/components/WatchVideoLiveChat/WatchVideoLiveChat.css
Outdated
Show resolved
Hide resolved
src/renderer/components/WatchVideoLiveChat/WatchVideoLiveChat.vue
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| .popoutChatIcon { | ||
| pointer-events: none; |
There was a problem hiding this comment.
The external link handling wouldn't trigger without this being set
With regular text inside the <a> element, it would trigger correctly. But with <FontAwesomeIcon> inside, it wouldn't without this.
Head branch was pushed to by a user without write access
3 participants
Pull Request Type
Related issue
closes #1721
Description
Adds a button that opens a new browser window with the current video live chat
Screenshots
Testing
Go to a video that is listed as "Live"
Click on the "Popout chat" button
See that the current video live chat is opened in a new browser window
Additional context
h4label was replaced withspanbecause of margin was stretching button hover animationthe margin is now applied to the container, replicating the same size as before but the height is ~10px less now