Draft: New product query API #267
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Won't build yet
This handles the API change, and ports the existing creator name check to work with the new product_query.
Contributor
Author
|
@phlexbot format |
Contributor
|
No automatic cmake-format fixes were necessary. |
Contributor
|
Automatic clang-format fixes pushed (commit e8b9e25). |
knoepfel
reviewed
Jan 26, 2026
| "cacheVariables": { | ||
| "CMAKE_EXPORT_COMPILE_COMMANDS": "YES", | ||
| "CMAKE_CXX_STANDARD": "20", | ||
| "CMAKE_CXX_STANDARD": "23", |
Member
There was a problem hiding this comment.
This change will have to wait until the CI container is built with ROOT configured with C++23. Won't be hard to do, just needs to be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of the new API requiring creator name to be specified.
After implementing this, I'm not sure creator name should be mandatory after all.
(Sorry, even this has turned into a huge PR, and some of the Jsonnet files got auto-formatted as JSON).