Fix JA4 cipher counting - #46
Merged
Merged
Conversation
igr001-galactica
approved these changes
Jan 26, 2026
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect JA4 cipher counts when clients send non-valid or unknown cipher suites.
The module previously used
SSL_get_client_ciphers(), which returns OpenSSL’s filtered cipher list and can drop unsupported ciphers. This caused JA4 to undercount. The fix switches toSSL_get0_raw_cipherlist(), using the raw ClientHello cipher list as sent by the client.A uTLS integration test was added to verify correct counting when unknown ciphers are present.