Skip to content

Fixes for memory issues causing crashes #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vlvkobal merged 1 commit into from
Nov 23, 2025
Merged

Fixes for memory issues causing crashes #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/ngx_http_ssl_ja4_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ int ngx_ssl_ja4(ngx_connection_t *c, ngx_pool_t *pool, ngx_ssl_ja4_t *ja4)
return NGX_ERROR;
}

ngx_memcpy(ja4->ciphers[*k], &hex, sizeof (hex));
/* hex is 4 chars + NUL; copy only the used portion */
ngx_memcpy(ja4->ciphers[*k], hex, 5);
(void)(*k)++;
}

Expand Down Expand Up @@ -287,7 +288,7 @@ int ngx_ssl_ja4(ngx_connection_t *c, ngx_pool_t *pool, ngx_ssl_ja4_t *ja4)

/* Signature Algorithms */

int num_sigalgs = SSL_get_sigalgs (ssl, -1, NULL, NULL, NULL, NULL, NULL);
int num_sigalgs = SSL_get_sigalgs (ssl, 0, NULL, NULL, NULL, NULL, NULL);

if (num_sigalgs > -1) {

Expand All @@ -297,7 +298,7 @@ int ngx_ssl_ja4(ngx_connection_t *c, ngx_pool_t *pool, ngx_ssl_ja4_t *ja4)
return NGX_ERROR;
}

for (int i = -1; i < num_sigalgs; ++i) {
for (int i = 0; i < num_sigalgs; ++i) {

int psign, phash, psignhash;
unsigned char rsig, rhash;
Expand Down