Repository navigation
ci(mend): fix mend sca scan of packages - #870
Merged
Merged
Conversation
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
View your CI Pipeline Execution ↗ for commit 5584e3d
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
===========================================
+ Coverage 18.07% 96.29% +78.22%
===========================================
Files 155 1 -154
Lines 24398 81 -24317
Branches 1203 17 -1186
===========================================
- Hits 4410 78 -4332
+ Misses 19988 3 -19985 🚀 New features to boost your workflow:
|
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/recognize
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
ancheetah
marked this pull request as ready for review
October 22, 2026 21:09
Contributor
|
Deployed 923ee2c to https://ForgeRock.github.io/ping-javascript-sdk/pr-870/923ee2c0d5b2e0b4c2fe0385b2c692d2cc77f1c6 branch gh-pages in ForgeRock/ping-javascript-sdk |
Contributor
Interface Mapping Out of DateThe Drift reportTo fix, run: pnpm mapping:generateThen commit the updated |
Contributor
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-95.4 KB, -100.0%) ➖ No Changes➖ @forgerock/recognize - 5605.5 KB 15 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
ancheetah
force-pushed
the
fix-mend-sca
branch
from
October 23, 2026 16:06
8254cb8 to
5584e3d
Compare
ancheetah
marked this pull request as draft
October 23, 2026 16:32
ancheetah
commented
Oct 23, 2026
| using: 'composite' | ||
| steps: | ||
| - uses: pnpm/action-setup@v4 | ||
| - name: Isolate package manifests in a temporary directory |
Collaborator
Author
There was a problem hiding this comment.
I opted for this approach instead of using the "exclude paths" flag for two reasons: (1) this method automatically excludes any folders external to 'packages/' that may be added in the future, (2) the "exclude paths" flag still scans off the root lockfile and includes deps from e2e and other tooling in the results.
ancheetah
marked this pull request as ready for review
October 23, 2026 18:59
ryanbas21
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
Description
Mend SCA scan was not scanning anything because the lockfile was excluded from the scan directory (
packages/). This stages just the manifests for the packages in a temporary directory for Mend to scan.Tested workflow dispatch with the new options here: https://github.com/ForgeRock/ping-javascript-sdk/actions/runs/39854405016
Interpreting the Mend SCA scan results:
https://pingidentity.atlassian.net/wiki/x/KQDT1g