fix: return device's primary ip for netbox services not explicitly bound to any IP#224
Open
koalajoe23 wants to merge 1 commit into
Open
fix: return device's primary ip for netbox services not explicitly bound to any IP#224koalajoe23 wants to merge 1 commit into
koalajoe23 wants to merge 1 commit into
Conversation
|
This pull request has been marked as stale because it has been inactive for more than 60 days. |
Contributor
Author
|
@FlxPeters Please take at look and respond |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
When a service has no explicit IP set, the "ipaddresses" label will not be set. A service with no explicit IP set will probably listen on all interfaces, so the primary IP should be returned. That way, "ipaddresses" can be used to get a valid IP to connect to that service regardless of configuration.
Issue ticket number and link
N/A
Checklist before requesting a review