refactor: Improve local cache speed#68
Conversation
…ing is the feature name.
emyller
left a comment
There was a problem hiding this comment.
Looks like a significant improvement! Added a few suggestions to contribute to performance and readability.
What is testToggle though? 🤔
|
I just started a new job on June and kinda busy with freelancing that I missed notification on this PR. Thanks for continuing! I’ll check for any pending task to have a look. |
No worries — thank you for the contribution so far!
@yuzurihaaa I believe I've addressed my own comments above. Please, if you have a chance, let me know if you agree with our contribution. We're aiming to merge and release this soon! |
emyller
left a comment
There was a problem hiding this comment.
Great contribution — thanks @yuzurihaaa!
Hi.
I realised that the cached uses quite a number of
firstWhereOrNullfor lookup. This PR changes to use Map so that getting flag value will be in O(1). I am currently thinking of using this but would also like some opinion from original maintainer on this idea :)Unit test result