mcstories: add a basic adapter for mcstories.com#4
Open
mscout1 wants to merge 1 commit intoFanFicDev:masterfrom
Open
mcstories: add a basic adapter for mcstories.com#4mscout1 wants to merge 1 commit intoFanFicDev:masterfrom
mscout1 wants to merge 1 commit intoFanFicDev:masterfrom
Conversation
| if m := story_index_path_re.fullmatch(path): | ||
| lid = m.group("lid") | ||
| elif m := story_chapter_path_re.fullmatch(path): | ||
| lid = m.group("clid") |
Member
There was a problem hiding this comment.
The clid group is only the same as lid for stories with a single chapter. So far every multi-chapter story I've checked switches to /{lid}/{lid}{cid}.html format.
I haven't caught a chapter that went from one to multiple chapters, but it also seems like /{lid}/{lid}.html gets a 404 at that point -- which maybe isn't a problem but something to be aware of.
Member
|
Overall this looks great, I appreciate the contribution! I'll need to do some small rebasing due to unpushed local changes to get it merged properly, but I've manually added it to the live site for now -- please feel free to test it out and let me know if you find any unexpected issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.