Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Fairmint OCF improvements index #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Add the Fairmint OCF improvements index #5
Changes from all commits
3c7fa39File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a reservation covers shares that are already outstanding, settling it with an issuance creates additional shares instead of moving or extinguishing the reserved shares. Under the extractor formula below, such an event both increases
outstandingand decreasesreserved; for example, consuming a 100-share reservation with a 100-share issuance turns 100 outstanding shares into 200. Limit consumption to transactions that act on the reserved position, or define a separate non-stock issuance mechanism that does not alter outstanding stock.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If “active reservations” means reservations with a remaining balance, this formula double-counts releases and consumes. After a 100-share reservation is fully released, it is no longer active, so the expression computes
0 - 100 = -100reserved shares. Either sum every posted reservation quantity before subtracting releases and consumes, or sum the remaining balances of active reservations without the subtractions.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.