-
Notifications
You must be signed in to change notification settings - Fork 1.4k
System manager interactions for FRR #20486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I want to create some code in zebra that should not have access to rib.h as that it does not need to know anything about rib operations. Let's move the MTYPE(ZEBRA) out of rib.h to allow the new files to not need rib.h Signed-off-by: Donald Sharp <[email protected]>
Add a high-level system-manager design doc and how I plan to go about doing this. Additionally it documents a bunch of simple steps to get this working. Signed-off-by: Donald Sharp <[email protected]>
This code does nothing more than start the zebra system-manager pthread and allow it to stop on shutdown. Signed-off-by: Donald Sharp <[email protected]>
The vscode editor wants to be informed about how FRR is built. Document how to make this happen to allow vscode to operate a bit better. Signed-off-by: Donald Sharp <[email protected]>
Add a initial context passing structure for the new sysmgr code. This is not really used at this point in time. Signed-off-by: Donald Sharp <[email protected]>
Allow the zebra master pthread to send a test message to the system manager pthread. Signed-off-by: Donald Sharp <[email protected]>
Let's add debugs so that we can follow what is going on. Signed-off-by: Donald Sharp <[email protected]>
Introduce this event into the system and add test code harness to show that it is received and handled. Signed-off-by: Donald Sharp <[email protected]>
Allow interested parties to receive notification when a PORTS_UP or PORTS_DOWN event has happened. Signed-off-by: Donald Sharp <[email protected]>
Add `sharp watch sysmgr`. This way we should be getting and seeing all sysmgr events. Signed-off-by: Donald Sharp <[email protected]>
Add a `show sharp sysmgr` command that will display information about the last sysmgr notification received. Signed-off-by: Donald Sharp <[email protected]>
Add a test that shows that zebra is able to send a sysmgr notifcation and upper level protocols can receive it. Signed-off-by: Donald Sharp <[email protected]>
|
I guess my initial reaction to the document is that I don't understand what this is actually ... going to do? Is zebra going to notice that "warm boot" is occurring? If so, what Similarly, what does "port reset" mean, and what will change in zebra I think I understand the "GR" event you've described, but that could I understand the machinery that's proposed, but I think it's premature |
See 2nd commit for a description of what is being done, as that it holds the design I worked towards.
Start the ability for FRR to interact with a system manager. Create test commands, ensure that they work.