bgp: ipv4 session comes up before ipv6 address is configured on link (BGP configured to AF6 && AF4)#20360
Merged
Jafaral merged 1 commit intoFRRouting:masterfrom Jan 21, 2026
Merged
Conversation
enissim
force-pushed
the
nexthop_4567664_A
branch
from
f91e97a to
e74a4fc
Compare
enissim
changed the title
enissim
changed the title
ton31337
requested changes
Jan 5, 2026
Member
ton31337
left a comment
ton31337
left a comment
There was a problem hiding this comment.
Squash all the commits to a single one and please write a topotest.
enissim
force-pushed
the
nexthop_4567664_A
branch
from
96cce9f to
90a073d
Compare
Member
|
Something sure seems like it has gone wrong. The FRR code base already has a bunch of these changes. Please force update to latest master and repush |
enissim
force-pushed
the
nexthop_4567664_A
branch
2 times, most recently
from
b89a640 to
af64272
Compare
Contributor
Author
|
Thanks for the review! |
enissim
force-pushed
the
nexthop_4567664_A
branch
from
af64272 to
3ca7f9b
Compare
Member
|
broken rebase? |
enissim
force-pushed
the
nexthop_4567664_A
branch
from
3ca7f9b to
91cff51
Compare
enissim
force-pushed
the
nexthop_4567664_A
branch
2 times, most recently
from
ff9970c to
e2d9806
Compare
donaldsharp
reviewed
Jan 7, 2026
donaldsharp
reviewed
Jan 7, 2026
enissim
force-pushed
the
nexthop_4567664_A
branch
from
e2d9806 to
92e0187
Compare
enissim
force-pushed
the
nexthop_4567664_A
branch
2 times, most recently
from
38bcadd to
b596e92
Compare
Member
|
Please fix the styling (frrbot). |
enissim
force-pushed
the
nexthop_4567664_A
branch
2 times, most recently
from
6730f4d to
b1be080
Compare
…BGP configured to AF6 && AF4) If there's no ipv6 address yet on the interfaces of the link connecting 2 peers, peer advertises prefixes with next hop ipv4 address mapped to ipv6 (::ffff+ipv4) Signed-off-by: Eyal Nissim <enissim@nvidia.com>
enissim
force-pushed
the
nexthop_4567664_A
branch
from
b1be080 to
0e54529
Compare
Contributor
Author
|
Addressed all feedback — PTAL when you have a moment. |
ton31337
approved these changes
Jan 8, 2026
ton31337
removed
documentation
ospf
zebra
docker
libfrr
mgmt
Member
|
@donaldsharp, are you fine with the changes? |
Contributor
Author
|
Hi Donald, |
Contributor
Author
|
Hi Donald, |
donaldsharp
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there's no ipv6 address yet on the interfaces of the link connecting 2 peers, peer advertises prefixes with next hop ipv4 address
mapped to ipv6 (::ffff+ipv4)