Fix stale OAuth sessions

src/client/_clientwindow.py

@@ -1210,7 +1210,9 @@ def try_to_auto_login(self) -> None:
             self.show_login_widget()
 
     def on_login_attempt_failed(self) -> None:
+        self.disconnect_()
         self.state = ClientState.DISCONNECTED
+        self._auto_relogin = False
         self.show_login_widget()
 
     def get_creds_and_login(self) -> None:

src/oauth/oauth_flow.py

@@ -99,6 +99,7 @@ def check_token_scopes(self) -> None:
 
     def on_request_failed(self, error: QOAuth2AuthorizationCodeFlow.Error) -> None:
         self._logger.error("Request failed with an error: %s", error)
+        self.setToken("")
         self.stop_checking_expiration()
 
     def setup_credentials(self) -> None:

tests/unit_tests/client/test_authentication.py

@@ -0,0 +1,28 @@
+from unittest.mock import call
+
+
+def test_login_failure_allows_fresh_connection(application, client_instance, mocker):
+    from src.client.clientstate import ClientState
+    from src.util.gameurl import GameUrl
+
+    disconnect = mocker.patch.object(client_instance, "disconnect_")
+    show_login_widget = mocker.patch.object(client_instance, "show_login_widget")
+    mocker.patch.object(client_instance, "_state", ClientState.LOGGED_IN)
+    mocker.patch.object(client_instance, "_auto_relogin", True)
+    lifecycle = mocker.Mock()
+    lifecycle.attach_mock(disconnect, "disconnect")
+    lifecycle.attach_mock(show_login_widget, "show_login_widget")
+
+    client_instance.on_login_attempt_failed()
+
+    assert client_instance.state == ClientState.DISCONNECTED
+    assert not client_instance._auto_relogin
+    assert lifecycle.mock_calls == [call.disconnect(), call.show_login_widget()]
+
+    mocker.patch.object(client_instance.replayServer, "doListen", return_value=True)
+    mocker.patch.object(client_instance.replayServer, "serverPort", return_value=12345)
+    connect = mocker.patch.object(client_instance.lobby_connection, "do_connect")
+    mocker.patch.object(GameUrl, "PORT", -1)
+
+    assert client_instance.do_connect()
+    connect.assert_called_once_with()

tests/unit_tests/oauth/test_oauth_flow.py

@@ -0,0 +1,11 @@
+def test_request_failure_discards_access_token(application):
+    from PyQt6.QtNetworkAuth import QAbstractOAuth
+
+    from src.oauth.oauth_flow import OAuth2Flow
+
+    flow = OAuth2Flow()
+    flow.setToken("expired-token")
+
+    flow.requestFailed.emit(QAbstractOAuth.Error.NetworkError)
+
+    assert flow.token() == ""