fix(vision-mixer): enforce framerate on PGM/MV outputs in GL passthrough#549
Merged
Merged
Conversation
The GPU pipeline path with gl_download=false (the default) had no capsfilter on either the PGM or multiview compositor output. As a result, the pgm_framerate and multiview_framerate properties were silently ignored whenever the GL-memory passthrough path was taken — the compositor produced at the input rate instead of the configured rate. In practice, PGM often appeared correct because downstream blocks (e.g. SDI/ EFP outputs with strict framerate caps) propagated their constraints back through caps negotiation, but the multiview output had no such downstream constraint and ran at the input rate. Add a capsfilter with `video/x-raw(memory:GLMemory)` features in both gl_download=false branches so the configured framerate/resolution is enforced while keeping buffers in GL memory. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
429a280 to
e3d5ceb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gl_download=false(the default) had no capsfilter on either the PGM or multiview compositor output, sopgm_framerateandmultiview_framerateproperties were silently ignoredvideo/x-raw(memory:GLMemory)features in bothgl_download=falsebranches so the configured framerate/resolution is enforced while keeping buffers in GL memoryRoot cause
In
vision_mixer/builder.rs, the GPU pipeline conditionally added agldownload + capsfilterchain whengl_download=true. Thegl_download=falsebranch went straight from compositor → tee → output queue with no caps constraint at all. With the defaultgl_download = false, themultiview_framerateproperty had no observable effect.Test plan
cargo checkcleancargo build(debug) cleancargo build --releasecleancargo test), incl.pipeline_lifecycle_testandopenapi_testmultiview_framerate=24/1) — observable inchrome://webrtc-internalsframesPerSecondfield🤖 Generated with Claude Code