Conversation
tobbee
force-pushed
the
issue-492
branch
6 times, most recently
from
71c1923 to
82aea70
Compare
Update actions/checkout v3/v4 to v5 and actions/setup-go v5 to v6 to avoid Node.js 20 deprecation warnings.
tobbee
force-pushed
the
issue-492
branch
4 times, most recently
from
c02fc9e to
279ecd5
Compare
Senc perSampleIVSize is now determined with correct priority: 1. seig sample group entry in traf 2. tenc defaultPerSampleIVSize from init segment 3. heuristic with saiz sample size validation When moov is not available during decode (separate init segment), the heuristic attempts parsing using saiz to validate candidates. If an init segment is later provided via the new ParseSenc() methods, the authoritative tenc value replaces any heuristic result. Key changes: - Add Fragment.ParseSenc() and MediaSegment.ParseSenc() for deferred senc parsing with a separate init segment - Add saiz-based validation to reject invalid IV size candidates - Track heuristic results via isParsedByGuess so they can be replaced - DecodeSenc now delegates to DecodeSencSR removing duplication - mp4ff-decrypt calls ParseSenc() when using a separate init file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #492
Fragment.ParseSenc(init)andMediaSegment.ParseSenc(init)for parsing senc boxes when the init segment is in a separate fileisParsedByGuessso authoritative tenc info from a laterParseSenc()call overrides themDecodeSencnow delegates toDecodeSencSRTest plan
mp4ff-infoon media segment without init still shows parsed senc details (heuristic path)mp4ff-decryptwith separate init + media segment works correctlyTestParseSencWithSeparateInitandTestParseSencWithSeig