feat(ui): rename Line/Lines to Call/Calls in calls page#620
Merged
Conversation
…L path Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
I think we need to handle redirect for a while if there are some links being reused out there... |
…→ /calls rename Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Auto-fix two prettier formatting errors in App.tsx: import list multi-line formatting and JSX attribute inline style. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- share-and-modals.spec.ts: getByText("Share Lines") to getByText("Share Calls")
- calls-page.spec.ts: test description "shows Lines header" to "shows Calls header"
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Saelmala
reviewed
Apr 7, 2026
| export function buildCallsUrl(calls: CallRef[], companionUrl?: string): string { | ||
| const base = | ||
| calls.length === 0 ? "/lines" : `/lines?lines=${encodeCallsParam(calls)}`; | ||
| calls.length === 0 ? "/calls" : `/calls?lines=${encodeCallsParam(calls)}`; |
Contributor
There was a problem hiding this comment.
should it instead of /calls?lines=... be /calls?calls=... ?
Saelmala
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/linesURL path to/callsinApp.tsxandcall-url.tsso the route is consistent with the "Calls" terminology used throughout the appcalls-page.tsxto say "Calls" instead of "Lines"join-production.tsxexit-call-button.tsx,settings-modal.tsx, andshare-line-link-modal.tsxto use Call/Calls terminologyuse-calls-navigation.test.tsandcall-url.test.tsto reflect the new/callspathTest plan
npm testinintercom-frontend/)npm run typecheck)npm run lint)/linesno longer matches a route (falls through to error page or redirects)/callsloads the calls page correctlybuildCallsUrl) use/calls?lines=...path🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com