Skip to content

Fix breadcrumbs in process-isolated hosts - #85

Merged
PrzemyslawKlys merged 1 commit into
masterfrom
fix/breadcrumbs-process-id
Sep 1, 2026
Merged

Fix breadcrumbs in process-isolated hosts#85
PrzemyslawKlys merged 1 commit into
masterfrom
fix/breadcrumbs-process-id

Conversation

@PrzemyslawKlys

Copy link
Copy Markdown
Member

Summary

  • use Environment.ProcessId for .NET 8 breadcrumb records so disabled or enabled breadcrumbs do not bind System.Diagnostics.Process
  • retain the existing Process.GetCurrentProcess().Id fallback for net472 and netstandard2.0
  • add an isolated assembly-load regression that rejects System.Diagnostics.Process, writes to a task-owned temporary breadcrumb file, verifies the PID, and cleans up
  • advance the core NuGet package version to 1.1.2

Why

The Website secure-share inspector runs FileInspectorX under systemd with ProtectProc=invisible and ProcSubset=pid. FileInspectorX 1.1.1 could fail before the disabled breadcrumb guard because the CLR had to bind System.Diagnostics.Process while compiling Breadcrumbs.Write. The worker then rejected a benign upload even though the file and inspection logic were valid.

This fixes the reusable FileInspectorX owner and keeps the Website integration as a thin package consumer. The process-isolation protections stay enabled.

Validation

  • the new regression failed on the old implementation with FileNotFoundException: System.Diagnostics.Process and passes after the change
  • full release suite: 1,226 net8 tests, 1,204 net472 tests, and 15 Magika tests passed
  • packed and inspected FileInspectorX.1.1.2.nupkg locally
  • the package's fixed net8 assembly returned Allow inside the unchanged hardened Linux Website worker with ProtectProc=invisible and ProcSubset=pid
  • independent local review found one test-hermeticity issue; it was fixed and the targeted confirmation found no remaining actionable P0-P2 issues

Release ordering

  1. Merge this owner change after current-head CI and review settle.
  2. Publish FileInspectorX 1.1.2 only through the separately authorized NuGet release step.
  3. Repin Website to the published three-part package version, deploy, and rerun its secure-share acceptance matrix.

The NuGet package has not been uploaded or published by this PR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T08:17:14.767353Z 5f16e3c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@PrzemyslawKlys
PrzemyslawKlys merged commit aca5fce into master Sep 1, 2026
3 checks passed
@PrzemyslawKlys
PrzemyslawKlys deleted the fix/breadcrumbs-process-id branch September 1, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant