Fix breadcrumbs in process-isolated hosts - #85
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Environment.ProcessIdfor .NET 8 breadcrumb records so disabled or enabled breadcrumbs do not bindSystem.Diagnostics.ProcessProcess.GetCurrentProcess().Idfallback for net472 and netstandard2.0System.Diagnostics.Process, writes to a task-owned temporary breadcrumb file, verifies the PID, and cleans up1.1.2Why
The Website secure-share inspector runs FileInspectorX under systemd with
ProtectProc=invisibleandProcSubset=pid. FileInspectorX 1.1.1 could fail before the disabled breadcrumb guard because the CLR had to bindSystem.Diagnostics.Processwhile compilingBreadcrumbs.Write. The worker then rejected a benign upload even though the file and inspection logic were valid.This fixes the reusable FileInspectorX owner and keeps the Website integration as a thin package consumer. The process-isolation protections stay enabled.
Validation
FileNotFoundException: System.Diagnostics.Processand passes after the changeFileInspectorX.1.1.2.nupkglocallyAllowinside the unchanged hardened Linux Website worker withProtectProc=invisibleandProcSubset=pidRelease ordering
FileInspectorX1.1.2 only through the separately authorized NuGet release step.The NuGet package has not been uploaded or published by this PR.