Skip to content

Upgrade vscode-languageclient to 8.1.0 - #162

Merged
jryans merged 1 commit into
Eugleo:masterfrom
dannypsnl:bump-vscode-languageclient-inlay-hints
Aug 25, 2026
Merged

jryans merged 1 commit into
Eugleo:masterfrom
dannypsnl:bump-vscode-languageclient-inlay-hints

Conversation

@dannypsnl

Copy link
Copy Markdown
Contributor

No description provided.

@jryans

jryans commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Is there a specific feature you’re looking for with this upgrade?

@dannypsnl

Copy link
Copy Markdown
Contributor Author

Yes, I recently working on inlay hints (racket-langserver) and found vscode-languageclient of magic-racket isn't supporting it.

Comment thread package.json

@jryans jryans left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, thanks! 😄

@jryans
jryans merged commit 2618f89 into Eugleo:master Aug 25, 2026
2 checks passed
@jryans

jryans commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

I'll work on releasing an updated extension with these changes.

@jryans

jryans commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

@dannypsnl Ah actually, maybe I should wait on the extension release here until after inlay hints have been added to the server, so that users get those features when upgrading all the parts together. (I assume inlay hints is still something in progress and not yet merged, if I understand correctly...?)

@dannypsnl

Copy link
Copy Markdown
Contributor Author

It should be fine, at racket-langserver we enable inlay hints from long time ago. We just never implement any inlay hints usage until now.

What user will see with new magic-racket should be: magic-racket and racket-langserver both enable inlay hints feature, racket-langserver will produce inlay hints for certain cases (what we're doing), e.g. field-name beside constructor, type beside define form.

@dannypsnl
dannypsnl deleted the bump-vscode-languageclient-inlay-hints branch August 25, 2026 13:06
@jryans

jryans commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Okay, I think I understand. I may still wait for at least one usage of inlay hints to merge to langserver before releasing / announcing the new extension version, as I that will make the upgrade more immediately interesting to users.

Thanks for working on all of this, quite exciting! 😄

@dannypsnl

Copy link
Copy Markdown
Contributor Author

Update jeapostrophe/racket-langserver#227

@jryans

jryans commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Just saw that come through, thanks for the update, quite exciting! 😄 I'll work on releasing the updated extension. It may take me a few days.

@jryans

jryans commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Published 0.9.0 to both marketplaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants