gps: Support multiconstellation NMEA#922
Open
Mixaill wants to merge 4 commits into
Open
Conversation
NMEA sentences use a two-digit hexadecimal checksum.
The `_recv()` function may return NMEA sentences with trailing carriage return and newline characters.
Modern GNSS receivers emit standard NMEA sentences (RMC, GGA, etc.) under multiple talker IDs (GP, GL, GA, etc.). Normalizes these sentences to their three-letter format, allowing the GPS logic to remain compatible with various multi-constellation receivers.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
This is a big change, will take time to review. It's not high on our priority. How did you try this? Did you put a third-party GPSDO into a B210 or X310? |
Author
Yes, I installed a third-party GPSDO receiver (based on u-blox m10) into the B210. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for correct handling of NMEA sentences with different talker IDs, such as
$GN,$GL,$GA, or$GB.Some third-party GNSS+OCXO / GPSDO are based on u-blox modules, and without changes, time synchronization is broken and the following warnings are generated:
Which devices/areas does this affect?
libuhdTesting Done
host/tests/gps_ctrl_test.cppChecklist