Skip to content

fix(#71): remove unused wrong flag parsing logic - #72

Merged
Escartem merged 2 commits into
Escartem:masterfrom
ihzgniqgnem:fix-#71
Aug 7, 2026
Merged

fix(#71): remove unused wrong flag parsing logic#72
Escartem merged 2 commits into
Escartem:masterfrom
ihzgniqgnem:fix-#71

Conversation

@ihzgniqgnem

Copy link
Copy Markdown
Contributor

This PR removes the incorrect flag parsing logic in Blb3File.ReadBlocksInfoAndDirectory to fix #71:

  • Flags should be inherent properties of nodes, not determined by their index in the array
  • The flags field is currently unused in the codebase, so this change doesn't affect existing functionality

This is my first time writing a PR, so please forgive me if there are any inappropriate parts.

@Escartem

Copy link
Copy Markdown
Owner

Will test in the next days if this doesn't cause any unwanted side effects and then will merge

@Escartem

Escartem commented Mar 17, 2026

Copy link
Copy Markdown
Owner

I have slightly modified the code again to keep the flag reading but without the issue you pinpointed, this should work now, feel free to comment again if you think it is still wrong, otherwise I'll commit within a few days

@Escartem

Escartem commented Aug 7, 2026

Copy link
Copy Markdown
Owner

@all-contributors add @ihzgniqgnem for bug and code

@allcontributors

Copy link
Copy Markdown
Contributor

@Escartem

I've put up a pull request to add @ihzgniqgnem! 🎉

@Escartem
Escartem merged commit 161b397 into Escartem:master Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logic error in BlbFile.cs:Blb3File.ReadBlocksInfoAndDirectory regarding BundleFile.Node.flags parsing

2 participants