Repository navigation
fix(how-it-works): the diagram's text line says whole step names - #605
Merged
Merged
Conversation
…line Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Checked the three changed lines in public/how-it-works.html against the SVG they read, and all six checks in the summary pass (install, typecheck, 1867 unit tests, e2e, actionlint, shellcheck).
What I verified rather than assumed:
#st-* text.bselects only the label lines. TheCode/AIbadge istext.tag, the per-step note istext.note, and the status label the render injects istext.state(public/how-it-works.html:537), so none of "working now", "✓ done", "150 DPI" or "Code" can leak into the joined label.- Joining each group's lines with a space reads correctly for all 16 steps — "Turn each page into an image", "Check HTML against the image (+ Code rules)", "Match Iris's words to the page's". The only label ending in punctuation (
st-pdf-review, "does it say what it shows?") is never added todoneinstagesFrom(:361-381), so the trailing?.case does not occur. - The
|| kfallback still fires:[].map(...).join(' ')is'', which is falsy. .map(label)is safe with map's extra(index, array)arguments —labeltakes one parameter.#diagram-stateis not inside thearia-liveregion (:86is the only one), so the longer string is not re-announced on each poll.
Non-blocking notes
- No assertion covers the fix.
test/how-it-works.test.ts:42lifts only the script's "pure" section (everything between// ----- Reading the logand// ----- State and API calls), so thediagram-stateline atpublic/how-it-works.html:548sits outside anything the suite reaches —stagesFromis tested, the sentence built from its output is not. The same class of regression (saying only part of a step's label) can come back silently. Latent: no delivered document is affected, and testing it needs the render run in jsdom, which the harness does not do today.
Accessibility impact: improves it — the screen-reader text line under the diagram now says each step's whole name instead of its first line only, and nothing in the delivered HTML path is touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iris Maintainer Agent here.
A follow-up to #604, found by checking the live page on iris.equalify.uic.edu. The text line under the diagram (the screen-reader version of its state) used only the first line of each step's label, so it read "Done so far: Your, Turn each page, Read the form's, …". It now joins each step's whole label and separates steps with semicolons: "Done so far: Your document; Turn each page into an image; Page agent writes the page's HTML; …". Checked in Chrome against a local Iris.
🤖 Generated with Claude Code