Skip to content

fix(FFESUPPORT-725): address Dependabot vulnerabilities#17

Merged
aarsilv merged 1 commit into
mainfrom
aarsilv/ffesupport-725/address-vulernabilities
May 22, 2026
Merged

fix(FFESUPPORT-725): address Dependabot vulnerabilities#17
aarsilv merged 1 commit into
mainfrom
aarsilv/ffesupport-725/address-vulernabilities

Conversation

@aarsilv
Copy link
Copy Markdown

@aarsilv aarsilv commented May 22, 2026

Summary

Closes FFESUPPORT-725.

Resolves all 8 open Dependabot alerts (3 high, 4 medium, 1 low) in this deprecated repository.

Changes

Verification

  • poetry install clean
  • poetry run pytest -v — 22/22 pass (matches the Tests workflow on Python 3.9–3.12)

Note

This PR was generated with Claude Code.

Resolves all 8 open Dependabot alerts (3 high, 4 medium, 1 low) in
this deprecated repository.

- pyproject.toml: bump pytest dev constraint ^7.4 -> ^8.4 to pull
  in 8.3.4+ which patches GHSA-6w46-j5rx-g56g (tmpdir handling).
- poetry update: refresh poetry.lock so transitive deps pick up
  patched versions:
    urllib3 -> 2.6.3 (GHSA-qccp-gfcp-xxvc, GHSA-mf9v-mfxr-j63j)
    deepdiff -> 8.6.2 (GHSA-54jj-px8x-5w5q)
    requests -> 2.32.5 (GHSA-gc5v-m9x4-r6x2)
    idna -> 3.16 (GHSA-65pc-fj4g-8rjx)
    dbt-common -> 1.34.2 (GHSA-w75w-9qv4-j5xj)
    sqlparse -> 0.5.4 (GHSA-27jp-wm6q-gp25)
    pytest -> 8.4.2 (GHSA-6w46-j5rx-g56g)
- 22/22 tests still pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Comment thread pyproject.toml

[tool.poetry.group.dev.dependencies]
pytest = "^7.4" # For running tests
pytest = "^8.4" # For running tests; >=8.3.4 patches GHSA-6w46-j5rx-g56g
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Context from Claude: Bumping pytest from ^7.4 to ^8.4. This is a major bump and pytest 8 has some real deprecation removals (e.g., pytest.warns(None), some collector class changes), but this project's test suite uses only the high-level API (pytest.fixture, pytest.raises, pytest_mock's mocker, simple parametrize), none of which is affected. All 22 tests pass locally on pytest 8.4.2 and the CI run on this PR has 3.9/3.10/3.11/3.12 all green. Sticking on pytest 7.x would leave GHSA-6w46-j5rx-g56g unpatched (advisory is fixed in 8.3.4+), and there is no 7.x backport.

@aarsilv
Copy link
Copy Markdown
Author

aarsilv commented May 22, 2026

🤖 Context from Claude: The poetry.lock diff is large because I ran an unscoped poetry update (not poetry update <pkg> for each advisory). Reason: every advisory in this repo is on a transitive dep, and several of them — urllib3, requests, idna, sqlparse — are pulled in by both dbt-core and the direct deps in different versions, so individually pinning them would have produced an inconsistent solve. Letting Poetry re-resolve the whole graph is the cleanest way to clear every advisory while letting Poetry settle on a single consistent set. Nothing was bumped past its declared semver constraint in pyproject.toml (except pytest, which I bumped intentionally — see inline comment on pyproject.toml).

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s development test dependency to a patched pytest release as part of resolving Dependabot-reported vulnerabilities in this repository.

Changes:

  • Bump pytest in dev dependencies from ^7.4 to ^8.4 to ensure a non-vulnerable version (>=8.3.4) is used.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aarsilv aarsilv marked this pull request as ready for review May 22, 2026 02:44
@aarsilv aarsilv enabled auto-merge May 22, 2026 02:48
@aarsilv aarsilv merged commit 88c925d into main May 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants