makefile(streamlit the same, stlite added, bug for display fixed, out…#21
Merged
makefile(streamlit the same, stlite added, bug for display fixed, out…#21
Conversation
…put as 0 as TD), and AGENTS.md added
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds stlite build scaffolding and contributor guidance while adjusting parameter loading/rendering to better support stlite (including handling nested YAML parameters: blocks and attempting to prevent blank widget values from overwriting defaults).
Changes:
- Add stlite build generation via
scripts/build_index.pyand a newMakefileworkflow. - Normalize YAML parameter defaults and add helpers for leaf-parameter defaults/coercion (stlite-specific).
- Add
AGENTS.mdcontributor/agent conventions and refactor parameter UI rendering/reset behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
utils/parameter_ui.py |
Refactors parameter reset/render logic and changes widget keying + sidebar rendering. |
utils/parameter_loader.py |
Adds typing, supports nested parameters: YAML layouts, and introduces get_leaf_defaults. |
scripts/build_index.py |
New helper to generate build/index.html for stlite and mount project files. |
app.py |
Adds stlite detection + parameter normalization/coercion; updates parameter source handling and UI flows. |
Makefile |
New targets for dev/stlite build/serve and quality checks. |
AGENTS.md |
New contributor/agent conventions and documented function contracts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thank you, @EddW1219! @olivia-banks, can you take a look at this PR? |
10 tasks
Member
|
Linking to #13. |
Member
|
@EddW1219 Do you have an ETA on this? |
Member
|
@copilot, please address the comments in #21 (review) and #21 (review) attn @olivia-banks @EddW1219 |
Member
- Add pandas-stubs, types-openpyxl, types-PyYAML to dev dependencies - All checks now pass: ruff, mypy, pytest - 91% coverage on utils/parameter_ui.py (changed code) - Addresses olivia-banks' review comments
EddW1219
force-pushed
the
edward_branch
branch
2 times, most recently
from
8b8e87f to
50b18e2
Compare
Collaborator
Author
|
@gvegayon @olivia-banks Hi George and Olivia, I just merged the changes to current PR. |
Member
|
This looks great to me, and I think it's ready to merge after we get #17 in here. |
Member
Member
Member
|
Resolved, waiting on merge. |
* [stash] draft * [stash] draft * [test] test! * [format] templating * [dep] dep * Update src/epicc/model/__init__.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/epicc/config/__init__.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [xlsx] support nested dict writes via dot-notation flattening * [yaml] use `ruamel` round-trip template to preserve trivia * Update src/epicc/formats/yaml.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [import] remove unused * [run] add shim * fix: address PR review comments from olivia-banks - Use Pyodide-recommended stlite detection (sys.platform/sys.modules) - Remove duplicate running_in_stlite() definition (F811) - Escape HTML labels with html.escape() in parameter_ui.py - Fix Makefile: UV ?= for env override, smelected typo, inline mkdir - Remove -> None from build_index.py main() - Fix AGENTS.md function contract for render_parameters_with_indent - Fix Excel reset callback to use consistent model_key Agent-Logs-Url: https://github.com/EpiForeSITE/epiworldPythonStreamlit/sessions/60bec289-6a09-4711-a403-13e7f0eb4742 Co-authored-by: gvegayon <893619+gvegayon@users.noreply.github.com> * [make] bring `Makefile` inline with new build script * [type] fix hinting --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: gvegayon <893619+gvegayon@users.noreply.github.com>
gvegayon
approved these changes
Apr 2, 2026
Member
gvegayon
left a comment
gvegayon
left a comment
There was a problem hiding this comment.
OK, I will let you fix any issues after merging, @olivia-banks and @EddW1219. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
running_in_stlite(): remove duplicate, use Pyodide-recommended detection (sys.platform == "emscripten")utils/parameter_ui.pywithhtml.escape()to prevent injectionUV ?= uv, fixsmelectedtypo, restructure$(BUILD_DIR)mkdir into INDEX_HTML rule-> Nonefrommain()inscripts/build_index.pyrender_parameters_with_indent