Repository navigation
fix(release): bootstrap the PTY session and outlive npm processing - #124
Merged
Merged
Conversation
The platform smoke typed @ on the sessionless launch surface, where file completion cannot open, so every Node 24 runner timed out before the launcher scenarios and the RC tag had to waive PTY. Create a session with a throwaway prompt first, then interrupt it; move provider/form editing to its unit suite so the PTY smoke stays on launcher-level behavior. npm's 141 MB CLI can remain invisible for well over ten minutes. Extend the visibility window to 40 minutes, and when npm answers E409 'previously staged', keep polling: the earlier publish may still be processing rather than waiting for a human 2FA approval. Only report approval guidance after that window closes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release runs fail repeatedly for two systemic reasons:
smoke-platform-pty.mjstyped@on the sessionless launch surface. File completion needs a live Agent, so all Node 24 runners timed out. Thewaive_platform_ptyinput only exists forworkflow_dispatch, so normal tag releases always failed after publishing.E409 previously staged versioneven when the earlier publish is still processing;npm stage listcan be empty.Fix
provider-add.spec.tsowns that behavior. The platform smoke now stays on launcher/terminal behavior.E409package for the same window before reporting approval guidance.Verification
node script/smoke-platform-pty.mjswith themayfly-hardeningprofile: PASS (linux-x64), scenariosboot, session, paste, edit, resize, file-completion, plugin-install, plugin-uninstall, exit-restore.pnpm run test:repo-workflow: 116 pass, 1 skip (includes the new staged-processing test).pnpm run typecheck,pnpm run lintpass.pnpm run build+check:pack: all three 0.1.4-rc.2 tarball SHA-512 values match npm, so a workflow_dispatch rerun will verify the already-published packages instead of republishing.