Repository navigation
fix(btw): keep the side conversation and its queue isolated - #122
Merged
Merged
Conversation
The native subagent activation settles a local child at its first idle and disposes it, so the BTW view closed as soon as the answer ended. Restore ownership of a regular AgentHandle: seed from buildForkSeed, hold the handle until the view closes, and clear the inherited inbox before asking so the parent's unclaimed queued and steering messages stay with the primary. Update the harnessAlignment btw and main goldens for the side view that now survives completion.
Collaborator
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/btwclosed itself as soon as the side answer completed.d5572320moved the side Agent to a nativesubagents.startActivation({ delivery: 'caller' }); the activation manager settles and disposes a local child at its first idle, andagent/disposedremoves the BTW conversation view.b6386624had cleared that inherited inbox, but the activation refactor dropped the clear, so/btwran the parent queue too.Fix
AgentHandlefromagents.createfor the side conversation; keep it until the view closes, is replaced, or the plugin unloads.buildForkSeed(parent.session.snapshotEvents(), lastSeq), restore the model/preset selection andhistoryFloorSeq, and clear the child inbox before asking the question.harnessAlignmentbtw/main goldens for the side view that now survives completion.Verification
pnpm run test— 6394 passed, 1 skipped.pnpm run check -- --base origin/main— lint, build, typecheck, agent docs, diagrams, workflow tests, and the 7 selected specs pass;harnessAlignmentpasses. The remainingmergeConversations/mergeHeights/mergePanelsscenario failures reproduce unchanged on a cleanorigin/mainworktree (stale queue/stats goldens), so they are not part of this change.check:libandcheck:packpass;btw-command.tshas 100% changed-file coverage.mayfly-btw-persistinstalled for human acceptance.Acceptance
dsh --profile mayfly-btw-persist: with a queued message on the primary,/btw <question>shows only that question; when the answer ends the side view stays open for follow-ups; Esc/F8/empty/btwcloses and disposes; F7 returns to main; new/btwreplaces the slot; 40/60 columns and theme reload stay clean.