Repository navigation
fix(rich-multi-select): forward maxOptions setting to tom-select - #23
Merged
Merged
Conversation
Search results were silently truncated at Tom Select's default of 50 options when consumers loaded large local catalogs (no remoteUrl). Forward settings.maxOptions from data-settings the same way sortField already is, so consumers can raise or disable the limit. Closes #22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RichMultiSelect(#buildConfig()) no reenviabasettings.maxOptionsa la configuración detom-select, por lo que siempre caía en el default detom-select(maxOptions: 50).remoteUrl), las búsquedas con más de 50 coincidencias se truncaban silenciosamente, perdiendo resultados válidos sin ningún indicador visual.settings.maxOptionsigual que ya se hace consortField, permitiendo a los consumidores subir o desactivar el límite víadata-settings.Closes #22
Test plan
usa maxOptions de data-settings) y test de comportamiento por defecto (no define maxOptions cuando no se configura)npm run lintsin erroresnpm run buildcompila correctamenteREADME.mdactualizado con la nueva opciónmaxOptionsexample/index.html+example/js/main.jsactualizados con demo comparando comportamiento con/sinmaxOptions🤖 Generated with Claude Code