feat(cdm): replace cooldown slots with active buffs - #1126
Open
mTx87 wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What does this PR do?
Adds an opt-in
Replace with Buffaction to cooldown and utility icon settings.A cooldown can be mapped to a Blizzard Cooldown Manager tracked buff. While that buff is active, its native Blizzard buff frame is routed into the cooldown's existing slot, preserving the slot's size, position, border, keybind, ordering, and Rotation Assist identity while showing the buff's native icon, duration, and stacks. When inactive or unavailable, the original cooldown is shown normally.
The picker includes Blizzard's tracked-buff catalog, including currently untalented entries. Custom Spell IDs are accepted only when they resolve to an existing Blizzard buff-viewer entry, and
cooldownIDdisambiguates catalog collisions. A tracked buff can replace only one cooldown slot.Mappings are stored in the cooldown's existing per-spec spell settings. No new event registrations or polling are added when no mappings exist.
How was it tested?
/mtx87cdmdiagnostics are not part of this branchgit diff --checkpasses and all added code is ASCII-onlyScreenshots
Before/after screenshots will be attached to the PR.
Checklist