Enable CUDA Graphs with vLLM Data Parallel#3020
Open
ihebchaa wants to merge 1 commit intoEleutherAI:mainfrom
Open
Enable CUDA Graphs with vLLM Data Parallel#3020ihebchaa wants to merge 1 commit intoEleutherAI:mainfrom
ihebchaa wants to merge 1 commit intoEleutherAI:mainfrom
Conversation
|
Iheb Chaabane seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Hi! thanks for the PR. Are you aware why they enforce eager if you follow their public API? |
Author
|
It's not clear to me why it's forced here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When using vLLM with data_parallel_size > 1, the current implementation forces enforce_eager=True, which disables CUDA graphs and significantly impacts performance. This is particularly problematic for Reasoning models that require large max_new_tokens (e.g., 32k+ tokens).
Solution:
this PR removes the forced enforce_eager=True when using data parallel.
Key Changes
Tests
Tested with tp=2 and dp (1, 2, 4) with a 7b reasoning model