Skip to content

use loop_all_device in c2p call#120

Merged
lwJi merged 2 commits intoEinsteinToolkit:developmentfrom
lwJi:c2p
Jan 15, 2026
Merged

use loop_all_device in c2p call#120
lwJi merged 2 commits intoEinsteinToolkit:developmentfrom
lwJi:c2p

Conversation

@lwJi
Copy link
Copy Markdown
Collaborator

@lwJi lwJi commented Dec 25, 2025

use loop_all over loop_bnd + loop_int + loop_ghost

  • simpler is better
  • launch one kernel is more efficient than launch multiple kernels
  • avoid potential race conditions
Screenshot 2025-12-25 at 09 45 16 Screenshot 2025-12-25 at 09 46 32

@jaykalinani
Copy link
Copy Markdown
Collaborator

Do you understand why the TOV test was failing, if indeed, loop_all = loop_bnd + loop_int + loop_ghost?

Copy link
Copy Markdown
Collaborator

@jaykalinani jaykalinani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MChabanov
Copy link
Copy Markdown
Collaborator

Looks good to me too!

@lwJi
Copy link
Copy Markdown
Collaborator Author

lwJi commented Jan 14, 2026

I don't know. on vista, they produce exactly the same results

@lwJi lwJi force-pushed the c2p branch 2 times, most recently from 885a09e to f33501d Compare January 14, 2026 21:17
@lwJi lwJi merged commit 5d6aec7 into EinsteinToolkit:development Jan 15, 2026
3 checks passed
@lwJi lwJi deleted the c2p branch January 15, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants