Skip to content

test: use Equal for succeed comparison #5881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Hoishin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: use Equal for succeed comparison #5881

Hoishin wants to merge 1 commit into from
+7 −1

Conversation

@Hoishin
Copy link
Contributor

@Hoishin Hoishin commented Dec 9, 2025 •
edited
Loading

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Test fix

Description

Node.js 24 has a change to deepStrictEqual for how it handles circular references in objects. Because of that, a test for BigDecimal.normalized is not passing. It seems to make sense to make use of Equal.equals when it is available, then fall back to deepStrictEqual.

Related

  • Related Issue #
  • Closes #

@Hoishin Hoishin requested a review from gcanti as a code owner December 9, 2025 08:14
@github-project-automation github-project-automation bot moved this to Discussion Ongoing in PR Backlog Dec 9, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

⚠️ No Changeset found

Latest commit: 0805ee2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcanti gcanti Awaiting requested review from gcanti gcanti is a code owner

Assignees

No one assigned

Labels

None yet

Projects

PR Backlog
Status: Discussion Ongoing

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Hoishin