Adding basic impact diagnostics

[lauracasp]

Description

Addition of basic impact diagnostics as listed in Table 1 of Elling et al 2026

! NOTE: In order to use the ORAS5 datasets on levante, the following configuration must be added to the .config/esmvaltool/data-hpc-dkrz.yml file in the native6 section:

      oras5:
        type: esmvalcore.io.local.LocalDataSource
        rootpath: /work/bd1083/b382555/extraobsraw
        dirname_template: "Tier{tier}/{dataset}/single_level" #{version}/{frequency}/{short_name}"
        filename_template: "{raw_name}_*.nc"

• Link to documentation: https://esmvaltool--4427.org.readthedocs.build/en/4427/recipes/recipe_climatic_impact-drivers.html

---

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines
• 🛠 Documentation is available
• 🛠 Tests run successfully
• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

• 🧪 Recipe runs successfully
• 🧪 Recipe is well documented
• 🧪 Figure(s) and data look as expected from literature
• 🛠 Provenance information has been added

---

To help with the number of pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[CLAassistant]

All committers have signed the CLA.

[LisaBock]

Thanks @lauracasp for this great diagnostics! It looks already quite good to me.

My comments are:

• I think, it would be helpful to include the used threshold in the output filename. Then it would be possible to collect all output files in the end in one directory.
• There are a lot empty files in the recipe. You can delete some of them.
• Other comments are below.

[lauracasp]

Thank you for the review and the suggestions! These should be implemented now, except for the .zenodo.json file, I will do that tomorrow.
About the filenames: I changed the default filenames to include the threshold, but kept the folder structure as it is for now. Would you recommend to change the folder structure also? Moreover, would be great if you could also take a quick look at the other changes if they resolve the issues sufficiently.

[LisaBock]

Thanks @lauracasp for all the changes!

Yes, I agree the folder structure is good as it is.

There are two more open comments regarding the files .zenodo.json and recipe_daily_era5.yml.

[lauracasp]

@LisaBock thanks! Both of the comments should also be resolved now.

[LisaBock]

Thanks @lauracasp ! Looks fine now to me!

[schlunma]

Thanks @lauracasp, looks great already! 🚀

I have a couple of (mostly minor) comments no the code, mostly about the figure caption and the ORAS5 dataset.

[schlunma]

Suggested change

	Recipes are stored in `recipes/climatic_impact-drivers`
	Recipes are stored in `recipes/climatic_impact_drivers`

To be consistent with other diagnostics, please use underscores in directory names

[schlunma]

There's a relative easy way to link the docstring of you diagnostic script here. For example, this is done in #4565:

The important files here are

• doc/sphinx/source/api/esmvaltool.diag_scripts.tropopause.cpt_hovmoeller.rst
• doc/sphinx/source/api/esmvaltool.rst

You can link to the diagnostic in the recipe documentation via

:ref:`cpt_hovmoeller.py <api.esmvaltool.diag_scripts.tropopause.cpt_hovmoeller>`

[schlunma]

What do "max", "mean", and "min" mean in this context? From what I understand, you're calculating the number of days where 40C is exceeded for each year and grid cell, and then calculate the max, mean, and min across all grid cells? Is that correct? If yes, I would remove the "Average" (why does it show max if it says "Average") and "at some point" (suggests you're looking at a single grid cell) from the plot title.

[schlunma]

Why did you choose to put this into a separate options setting? I think it would be simpler to just add this to the other recipe configuration options below without the additional options layer.

[schlunma]

Some of our preprocessors may add this coordinate without calculating a threshold (e.g., daily_statistics), so this is rather dangerous. It might be better to check if the long name already contains "Average number of days per year on which the"

[schlunma]

I would suggest either replacing ORAS5 with another dataset if possible or removing this variable altogether. Having absolute paths in a published recipe is never a good idea (the recipe won't run on other machines than Levante), and there is no way to use ORAS5 without explicitly specifying a horizontal grid (which IMHO is really bad):

https://github.com/ESMValGroup/ESMValCore/blob/936450c81d6b00ede72947310fc04e322c7654c1/esmvalcore/cmor/_fixes/native6/oras5.py#L126-L135

This comment applies to all appearances of ORAS5 in both recipes.

[schlunma]

I just had another look at this. Turns out the grid file can be given relative to the auxiliary_data_dir, which at least avoids having to specify absolute paths in recipes. Nevertheless, we would need to set up a proper ORAS5 directory in our OBS pool on Levante (and on other machines in the future, too) before we can include this so that this recipe can be run without special configuration settings @ESMValGroup/obs-maintainers. This should have been done before merging ESMValGroup/ESMValCore#2422.