Update obs4MIPs tables - #3194
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3194 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 280 280
Lines 16282 16294 +12
=======================================
+ Hits 15711 15723 +12
Misses 571 571 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
valeriupredoi
left a comment
There was a problem hiding this comment.
this is mega, very many thanks, Manu! Ping me when you ready for a review 🍺
|
This is ready now from my side. |
valeriupredoi
left a comment
There was a problem hiding this comment.
many thanks, Manu! @bouweandela you mind giving this one a cursory look too ples (a LOT of stuff, so I might have missed smth), and merge plss 🍻
|
Description
I've been working with obs4MIPs data a lot recently, which can be quite frustrating because our tables are very outdated. This PR updates the tables to the most recent commit (note that the latest released version is also very old (>3.5 years)).
Couple of additional things I found:
institutefacet for obs4MIPs data.gridfor obs4MIPs datasets to fully describe them (it works without it because in 99% of cases the grid isgn, but technically we need it). We might consider updating our recipes accordingly.Backwards-incompatible change #
Removal of tables
The following tables have been removed:
obs4MIPs_monNobs.json(with single variablendviNobs)obs4MIPs_monStderr.json: (with single variablendviStderr)Those cannot be used anymore.
Closes #1890
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
🛠 Changes are backward compatibleTo help with the number pull requests: