site: derive installable and upcoming component counts from catalog data#200
Open
highoncomputers wants to merge 1 commit into
Open
site: derive installable and upcoming component counts from catalog data#200highoncomputers wants to merge 1 commit into
highoncomputers wants to merge 1 commit into
Conversation
…ata (Ducksss#131) Instead of hard-coding '58 installable' and '8 in development' in site copy, compute the counts from componentEntries and upcomingComponents. The derived values sit right after the arrays so they can never drift from what the catalog actually ships. - Add installablePageCount and upcomingPostCount exports - componentsIntro now uses a template literal with derived counts - componentFamilies.pages.countLabel and .posts.countLabel derive from data - about page intro uses the derived counts instead of hard-coded text - Existing fumadocs-site.int.spec.ts already asserts against derived values Closes Ducksss#131
|
@highoncomputers is attempting to deploy a commit to the ducksss' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The catalog intro and component-family labels hard-code install counts: "Fifty-eight page blocks install today" and "8 post components." Every time a new component ships, someone has to remember to update these strings — and the ROADMAP refresh in #196 showed exactly how easy it is for them to drift.
Solution
Derive the counts from
componentEntriesandupcomingComponentsso they always match what the catalog actually ships. The derived values sit right after the arrays insite.ts, so future component additions update the copy automatically.Changes
installablePageCountandupcomingPostCount— new exports computed from the catalog arrayscomponentsIntro— switched from a hard-coded string to a template literal with derived countscomponentFamilies.pages.countLabeland.posts.countLabel— derive from data instead of hard-codingfumadocs-site.int.spec.ts) already asserts against derived values — no test changes neededCloses #131