[DRAFT] major rewrite for v2.0-preview#18
Merged
binary1230 merged 146 commits intoDizTools:masterfrom Oct 29, 2020
Merged
Conversation
I'm afraid these settings only work for my PC (125%), though...
The low byte of DP was affecting the opcode itself.
- store comments specific to labels - print label comments in labels.asm - print all labels in all-labels.txt for analysis - update save file format to v2 - refactor save file code, combine all versions into one
it can now deal with being pasted stuff like: $C1/08A7 probably needs a bit more testing to make sure validation handles ROM memory bounds correctly, etc.
- faster - allow selection of multiple files - add progress bar UI funtionality
…ess level - also, move RomMapMode and RomSpeed out of Data
- was incorrectly adding an extra line add unit tests!
… of a wash for optimization but a little neater, so leaving it. - add unit tests for performance testing load/save
# Conflicts: # DiztinGUIsh/window/dialog/BSNESTraceLogBinaryMonitorForm.UI.cs
Collaborator
Author
5 tasks
Collaborator
Author
|
@gocha I just wanted to show you since you wrote the original code, I extended it and added BSNES support to be able to read the same tracelog data in realtime over a socket. Combined with the new visual window, you can literally watch the ROM get marked up in realtime in Diztinguish: This is a sped up video of about a 1 minute run (full version is here: https://www.youtube.com/watch?v=NCZUESf82Rg&feature=youtu.be) I put the details in the BSNES pull request I just opened: devinacker/bsnes-plus#268 |
…o do this but, doesn't hurt)
…e instead of a full compare
…lass is NEVER serialized
- attempted to divide and conquer lots of form elements here into 7 partial classes - mostly for organizing, lays the groundwork for future refactoring - makes it easier to mentally digest the important bits separate from the glue
Collaborator
Author
|
alright, I checked off the main items on my list and I'm ready to merge this back into master. I still want to clean up some further things before we do an official 2.0 release but, it's pretty stable. I'll get a preview build out shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


[DRAFT DO NOT MERGE YET]
This pull request is a pretty major rewrite of most parts of Diztinguish.
Major: Code architecture overhaul
Major: New XML-based save format
Minor:
I opened this pull request mostly to track remaining open issues. When it's in, I'd like to consider the codebase as 2.0-preview1 and continue further testing ahead of a release.
Files have been moved around heavily, so I expect the diffs here to be pretty ugly. As a result I was fairly careless with my checkins. Honestly, I might delete this branch and re-create with a squashed commit that puts all this in one commit. After this stuff is in, we'll get back to a more normal github flow workflow.
Before merging this PR:
Before releasing 2.0:
@Dotsarecool can I get maintainer access to repo? And thanks for writing such a great tool. I am having a lot of fun working on it, though my spare time is kinda limited at the moment.