Skip to content

Fix screen staying ON after calls by managing FLAG_KEEP_SCREEN_ON correctly#86

Open
DivyanshuChipa wants to merge 1 commit intomasterfrom
fix-proximity-screen-flag-9048104886047945714
Open

Fix screen staying ON after calls by managing FLAG_KEEP_SCREEN_ON correctly#86
DivyanshuChipa wants to merge 1 commit intomasterfrom
fix-proximity-screen-flag-9048104886047945714

Conversation

@DivyanshuChipa
Copy link
Copy Markdown
Owner

This PR fixes an issue where the screen would remain on indefinitely after a call ended due to the FLAG_KEEP_SCREEN_ON flag not being cleared.

Changes:

  1. ProximitySensor.kt: Modified deactivate() to take a boolean keepScreenOn. If false, it clears the flag.
  2. MainActivity.kt: Updated all call sites to use the new parameter. It now clears the flag on call cleanup and activity destruction, while maintaining it for speaker mode.

PR created automatically by Jules for task 9048104886047945714 started by @DivyanshuChipa

- Update ProximitySensor.kt to allow explicit control of KEEP_SCREEN_ON flag via deactivate(keepScreenOn: Boolean).
- Update MainActivity.kt to clear the flag when calls end, preventing the screen from staying on indefinitely.
- Ensure the flag is kept only when speaker mode is active or during call initiation.

Co-authored-by: DivyanshuChipa <211708943+DivyanshuChipa@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant