🔒 Fix Path Traversal Vulnerability in File Upload/Retrieval#85
🔒 Fix Path Traversal Vulnerability in File Upload/Retrieval#85DivyanshuChipa wants to merge 1 commit intomasterfrom
Conversation
- Use pathlib.Path.resolve() and is_relative_to() for robust containment check. - Ensure requested path is a file and not the upload directory itself. - Add explicit check for empty filenames from _safe_filename. - Improve error reporting with appropriate HTTP status codes (400, 403, 404). Co-authored-by: DivyanshuChipa <211708943+DivyanshuChipa@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3625c6742
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| path = (UPLOAD_DIR / filename).resolve() | ||
| base = UPLOAD_DIR.resolve() | ||
|
|
||
| if not path.is_relative_to(base) or path == base: |
There was a problem hiding this comment.
The new check uses Path.is_relative_to, which is only available in Python 3.9+, but this repository documents Python 3.8+ support (README.md line 12). On Python 3.8, every request to this endpoint will raise AttributeError at runtime and return a 500 instead of serving files or returning the intended 4xx errors. Please switch to a 3.8-compatible pattern such as path.relative_to(base) inside a try/except ValueError block.
Useful? React with 👍 / 👎.
1 participant
🎯 What: Fixed a path traversal vulnerability in the
⚠️ Risk: An attacker could potentially read arbitrary files from the server's filesystem by crafting malicious filenames (e.g., using
get_uploaded_fileendpoint inbackend/files.py...sequences) if they bypassed the basicos.path.basenamecheck.🛡️ Solution: Implemented robust path validation using
pathlib. The requested path is now resolved and verified to be strictly relative to the designatedUPLOAD_DIR. Additionally, the endpoint now explicitly ensures that only files (not directories) are served and handles empty or invalid filenames with appropriate HTTP error codes.PR created automatically by Jules for task 6351226568896084827 started by @DivyanshuChipa