Prototype proofreading interface #1456
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismiceli
reviewed
Mar 15, 2025
Collaborator
chrismiceli
left a comment
chrismiceli
left a comment
There was a problem hiding this comment.
Going to review more closely, but not getting too critical until we align on design etc.
| $header_args = [ | ||
| "css_files" => [ | ||
| "$code_url/styles/struct.css", | ||
| "https://cdn.jsdelivr.net/npm/[email protected]/dist/quill.core.css", |
Collaborator
There was a problem hiding this comment.
should we just serve js/css from our domain since our user base is very sensitive to external resources?
Collaborator
Author
There was a problem hiding this comment.
Yes we should, It didn't seem very clear to me how to download the files so I took the easy way and had to change pinc/base.inc to make this work.
Collaborator
There was a problem hiding this comment.
Looks like the css nor js have any imports or external references, so should just be able to paste into our external resources folder (/pinc/3rdparty) with appropriate license and details.json file.
Collaborator
Author
|
Sandbox updated. |
Collaborator
Author
|
Sandbox updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is incomplete. There is minimal styling. The styles in the file struct.css are important for the structure of the pages but do not specify any colours (except to avoid transparent which would allow what is underneath to show through). There are several unused files remaining.
Sandbox at: https://www.pgdp.org/~rp31/c.branch/pi_2025