Skip to content

Add an integration test for the verifier reject flow updating queue and history #491

Description

@1nonlypiece

📌 Description

The existing verifier integration test covers approve. A complementary
integration test should drive the reject path from ValidationDetail through the
verifier store, asserting the task leaves the pending queue and lands in history
as rejected with notes.

🎯 Requirements and Context

  • Open a task, check criteria, reject with notes, confirm in modal.
  • Assert the task is removed from pending and present in history as rejected.
  • Assert the notes are persisted on the history record.

🛠️ Suggested Execution

1. Fork the repo and create a branch

git checkout -b test/verifier-reject-flow

2. Implement changes

  • Extend src/pages/__tests__/verifierFlow.integration.test.tsx.

3. Test and commit

  • Run npm test.
  • Cover edge cases: reject without notes, criteria gate blocks reject if
    required, history reflects status, queue count decremented.

Example commit message

test: verifier reject flow queue-to-history integration coverage

✅ Guidelines

  • Minimum 95% test coverage on the new/changed lines.
  • RTL-based integration assertions.
  • Timeframe: 96 hours.

🏷️ Labels

type-testing · area-frontend · MAYBE REWARDED · GRANTFOX OSS · OFFICIAL CAMPAIGN

💬 Community & Support

  • Join the Disciplr contributor Discord to coordinate, ask questions, and get
    unblocked fast: https://discord.gg/xvNAvMJf
  • Please introduce yourself in the channel before you start so we can avoid
    duplicate work, pair you with a reviewer, and get your PR merged quickly.
  • Maintainers actively triage this channel and aim for fast, clear, respectful
    reviews — reach out any time you're blocked.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GRANTFOX OSSGrantFox open-source campaignMAYBE REWARDEDEligible for GrantFox rewardOFFICIAL CAMPAIGNOfficial GrantFox campaign issueStellar WaveIssues in the Stellar wave programarea-frontendFrontend / UI worktype-testingTests and test coverage

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions