Conversation
…warning Codex maps a hook systemMessage to a Warning entry and de-greens the completed-hook bullet, so ponytail's PONYTAIL:<MODE> reads as an error every session (DietrichGebert#605). Drop it: the mode still surfaces via the additionalContext "hook context:" line for every state (active level when on, PONYTAIL MODE OFF when off) and the bullet goes green. Tests updated.
|
Confirming this on Codex CLI 0.147.0 / macOS with Ponytail 4.9.0. Worth flagging that it isn't warning-only on this Codex version: the Applying this patch — dropping the Codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Codex, every SessionStart shows ponytail's mode as a yellow
warning:line that reads like an error (#605):This is distinct from #331 / openai/codex#16933 (Codex rendering
additionalContext) — this line is ponytail's ownsystemMessage.Fix
Drop
systemMessagein theisCodexbranch ofhooks/ponytail-runtime.js. Codex maps a hooksystemMessageto aWarningentry, and anyWarningentry also de-greens the completed-hook bullet (codextui/src/history_cell/hook_cell.rs). Removing it:warning:line,hook context:line —level: <mode>when on,PONYTAIL MODE OFFwhen off (that path passes context too), since Codex rendersadditionalContext.So no loss of visibility, only the alarming styling goes. The
isCodexbranch is now identical toisQoder— glad to dedup them if you'd prefer.Tests
npm test— updated the codex assertions intests/hooks.test.jsto assert nosystemMessageand confirm the mode/off state still surfaces viaadditionalContext. (The pre-existingtests/correctness.test.jscsv failure is unrelated — it fails on cleanmainhere too.)Fixes #605