Skip to content

Various small changes from beamline#1695

Merged
noemifrisina merged 1 commit intomainfrom
1683-Pulling_Changes_From_Beamline
Apr 10, 2026
Merged

Various small changes from beamline#1695
noemifrisina merged 1 commit intomainfrom
1683-Pulling_Changes_From_Beamline

Conversation

@adaudon
Copy link
Copy Markdown
Contributor

@adaudon adaudon commented Apr 10, 2026

Fixes #1683

Link to dodal PR (if required): #1991
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@adaudon adaudon requested a review from a team as a code owner April 10, 2026 14:02
@adaudon adaudon requested a review from noemifrisina April 10, 2026 14:03
@adaudon adaudon added the i24 Changes relating to I24 label Apr 10, 2026
@adaudon adaudon force-pushed the 1683-Pulling_Changes_From_Beamline branch from a297b0c to bb0d4ef Compare April 10, 2026 14:54
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.87%. Comparing base (ab5ce12) to head (bb0d4ef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1695   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files         155      155           
  Lines        8495     8495           
=======================================
  Hits         7890     7890           
  Misses        605      605           
Components Coverage Δ
i24 SSX 77.35% <100.00%> (ø)
hyperion 98.59% <ø> (ø)
other 98.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@noemifrisina noemifrisina merged commit 2c1cd80 into main Apr 10, 2026
25 of 29 checks passed
@noemifrisina noemifrisina deleted the 1683-Pulling_Changes_From_Beamline branch April 10, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i24 Changes relating to I24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I24ssx: pull in changes/fixes from the beamline

2 participants