Skip to content

Update EDM for I24 detctor stage#1694

Merged
adaudon merged 4 commits intomainfrom
1684-Update-EDM
Apr 10, 2026
Merged

Update EDM for I24 detctor stage#1694
adaudon merged 4 commits intomainfrom
1684-Update-EDM

Conversation

@phathaway
Copy link
Copy Markdown
Contributor

Fixes #1684

Link to dodal PR (if required): #XXX
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@phathaway phathaway requested a review from a team as a code owner April 10, 2026 13:39
@phathaway phathaway added the I24 serial Issues relating to ssx on I24 label Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.87%. Comparing base (2c1cd80) to head (53b1c43).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1694   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files         155      155           
  Lines        8495     8495           
=======================================
  Hits         7890     7890           
  Misses        605      605           
Components Coverage Δ
i24 SSX 77.35% <ø> (ø)
hyperion 98.59% <ø> (ø)
other 98.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@adaudon adaudon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@adaudon adaudon merged commit 231394a into main Apr 10, 2026
26 of 29 checks passed
@adaudon adaudon deleted the 1684-Update-EDM branch April 10, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I24 serial Issues relating to ssx on I24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I24ssx: update all edms to use new detector stage PVs

3 participants