Skip to content

Fix system tests#1686

Open
jacob720 wants to merge 11 commits intosimplify_config_file_paramsfrom
27_3_26_fix_system_tests
Open

Fix system tests#1686
jacob720 wants to merge 11 commits intosimplify_config_file_paramsfrom
27_3_26_fix_system_tests

Conversation

@jacob720
Copy link
Copy Markdown
Contributor

@jacob720 jacob720 commented Mar 30, 2026

Fixes

Fixes system tests broken by us now reading detector config through the config server, and changes made to injection of the config client.

Also requires daq config server changes (and hyperion-system-test container image built against them) :

Hyperion system test container changes for daq-config-server merge request:
https://gitlab.diamond.ac.uk/MX-GDA/hyperion-system-testing/-/merge_requests/9

Instructions to reviewer on how to test:

  1. Confirm system tests pass

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@jacob720 jacob720 requested a review from a team as a code owner March 30, 2026 12:03
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.87%. Comparing base (6279503) to head (6d2126e).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           simplify_config_file_params    #1686      +/-   ##
===============================================================
- Coverage                        92.87%   92.87%   -0.01%     
===============================================================
  Files                              154      154              
  Lines                             8493     8488       -5     
===============================================================
- Hits                              7888     7883       -5     
  Misses                             605      605              
Components Coverage Δ
i24 SSX 77.35% <ø> (ø)
hyperion 98.59% <ø> (ø)
other 98.30% <ø> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacob720 jacob720 added the dev experience Changes relating to developer experience label Mar 31, 2026
@rtuck99 rtuck99 force-pushed the 27_3_26_fix_system_tests branch from f522cf8 to 6d2126e Compare April 16, 2026 16:06
@rtuck99 rtuck99 changed the base branch from main to simplify_config_file_params April 16, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants