Open
Conversation
rtuck99
force-pushed
the
1400_hyperion_commissioning_plans
branch
from
7f44373 to
f7a19e5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1685 +/- ##
==========================================
+ Coverage 92.87% 92.90% +0.02%
==========================================
Files 155 156 +1
Lines 8495 8530 +35
==========================================
+ Hits 7890 7925 +35
Misses 605 605
🚀 New features to boost your workflow:
|
…ect parameters, in favour of specifying the pin type.
rtuck99
force-pushed
the
1400_hyperion_commissioning_plans
branch
from
a24efdb to
e155d82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1400
Link to dodal PR (if required): #N/A
(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Exposes
pin_centre_then_xray_centre_planvia blueapi and also removes some of the agamemnon parameter comparison logic that is no longer used by anything.Related Gerrit change:
https://gerrit.diamond.ac.uk/c/gda/gda-mx/+/44819
see also
https://gerrit.diamond.ac.uk/c/gda/gda-mx/+/44868 which completely guts HCR and allows calling load_centre_collect from GDA
Instructions to reviewer on how to test:
Checks for reviewer