Add vmxm gridscan plan#1636
Open
olliesilvester wants to merge 5 commits into364_make_nexus_callbacks_genericfrom
Open
Add vmxm gridscan plan#1636olliesilvester wants to merge 5 commits into364_make_nexus_callbacks_genericfrom
olliesilvester wants to merge 5 commits into364_make_nexus_callbacks_genericfrom
Conversation
olliesilvester
changed the base branch from
main
to
364_make_nexus_callbacks_generic
This was referenced Feb 18, 2026
Closed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 364_make_nexus_callbacks_generic #1636 +/- ##
====================================================================
+ Coverage 92.83% 92.88% +0.04%
====================================================================
Files 157 160 +3
Lines 8566 8652 +86
====================================================================
+ Hits 7952 8036 +84
- Misses 614 616 +2
🚀 New features to boost your workflow:
|
jacob720
reviewed
Feb 25, 2026
Contributor
jacob720
left a comment
jacob720
left a comment
There was a problem hiding this comment.
Looks good, just a couple comments.
|
|
||
|
|
||
| @pydantic.dataclasses.dataclass(config={"arbitrary_types_allowed": True}) | ||
| class FlyScanXRayCentreComposite(FlyScanEssentialDevices[GonioWithOmegaType]): |
Contributor
There was a problem hiding this comment.
Could: call this VMXmFlyScanXRayCentreComposite or I021FlyScanXRayCentreComposite
| from mx_bluesky.common.utils.log import LOGGER | ||
|
|
||
|
|
||
| def create_gridscan_callbacks() -> tuple[ |
Contributor
There was a problem hiding this comment.
This looks identical to the i04 one, could we put it somewhere common?
Contributor
There was a problem hiding this comment.
Nevermind, this has SpecifiedTwoDGridScan and i04 has SpecifiedThreeDGridScan
jacob720
approved these changes
Feb 26, 2026
1 task
Contributor
Author
|
I'm going to hold off on merging this until #1623 is merged |
olliesilvester
force-pushed
the
add_vmxm_gridscan_plan
branch
2 times, most recently
from
78dac28 to
22ec8d2
Compare
olliesilvester
force-pushed
the
add_vmxm_gridscan_plan
branch
from
22ec8d2 to
638a8c1
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #1623 and DiamondLightSource/dodal#1925
Supersedes #924 and #1214
Note that these gridscans don't have ispyb integration. That is coming in a later PR
Link to dodal PR (if required): #XXX
(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Instructions to reviewer on how to test:
Checks for reviewer