Complete the baseline summation integrator#92
Open
jbeilstenedmands wants to merge 11 commits intomainfrom
Open
Complete the baseline summation integrator#92jbeilstenedmands wants to merge 11 commits intomainfrom
jbeilstenedmands wants to merge 11 commits intomainfrom
Conversation
Collaborator
Author
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Collaborator
Author
|
Ok, there is some difference coming from the slightly different foreground/background segregation algorithm compared to dials. However this baseline integrator is currently missing robust background modelling - dials removes outliers from the background array, even for constant3d model (using glm method), so this needs adding before we can check equivalence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Complete the baseline c++ integrator implementing summation integration.
Input can be the output from the baseline indexer, predicted data, or predicted data containing bboxes.
Outputs a reflection table with sufficient content to be usable for dials.symmetry and dials.scale.
Slow as not yet parallelized over cpu threads, but useful for testing and comparisons. Close to dials equivalence, not expected to be fully equivalent as slightly different approach used for classifying foreground and background.