i15-1: make bluesky buttons log-in dependent#29
Conversation
EmsArnold
left a comment
There was a problem hiding this comment.
Looks good to me, with one comment: would be good to open an issue to address mocks in the future.
douglaswinter
left a comment
There was a problem hiding this comment.
This will break ViSR. Changes to the base helm chart should either be done via templating, or corresponding changes should be made to other app subcharts!
I thought I had already but apparently not, will get to that. The issue with the mocks is that to have the mocks working we'll need to change how we do handleLogIn and handleLogOut (as msw can't intercept window calls as they are) |
Thanks to @JamesDoingStuff this should be fixed now |
Disable the buttons running blueapi plans for non-logged in users and add a login/logout button to the navbar