Skip to content

i15-1: make bluesky buttons log-in dependent#29

Merged
noemifrisina merged 43 commits intomainfrom
i15-try-login
Apr 10, 2026
Merged

i15-1: make bluesky buttons log-in dependent#29
noemifrisina merged 43 commits intomainfrom
i15-try-login

Conversation

@noemifrisina
Copy link
Copy Markdown
Collaborator

@noemifrisina noemifrisina commented Mar 13, 2026

Disable the buttons running blueapi plans for non-logged in users and add a login/logout button to the navbar

Copy link
Copy Markdown
Contributor

@EmsArnold EmsArnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with one comment: would be good to open an issue to address mocks in the future.

Copy link
Copy Markdown
Collaborator

@douglaswinter douglaswinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break ViSR. Changes to the base helm chart should either be done via templating, or corresponding changes should be made to other app subcharts!

@noemifrisina
Copy link
Copy Markdown
Collaborator Author

Looks good to me, with one comment: would be good to open an issue to address mocks in the future.

I thought I had already but apparently not, will get to that. The issue with the mocks is that to have the mocks working we'll need to change how we do handleLogIn and handleLogOut (as msw can't intercept window calls as they are)

@noemifrisina
Copy link
Copy Markdown
Collaborator Author

This will break ViSR. Changes to the base helm chart should either be done via templating, or corresponding changes should be made to other app subcharts!

Thanks to @JamesDoingStuff this should be fixed now

@noemifrisina noemifrisina merged commit 7780a74 into main Apr 10, 2026
4 checks passed
@noemifrisina noemifrisina deleted the i15-try-login branch April 10, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants