Skip to content

LIMS-2146: Always display all detectors#1058

Open
ndg63276 wants to merge 1 commit intomasterfrom
fix/LIMS-2146/not-all-detectors-are-displayed
Open

LIMS-2146: Always display all detectors#1058
ndg63276 wants to merge 1 commit intomasterfrom
fix/LIMS-2146/not-all-detectors-are-displayed

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

@ndg63276 ndg63276 commented Apr 1, 2026

JIRA ticket: LIMS-2146

Summary:

The beamline setups page only displays 5 detectors by default, and this means you can only select form those 5 when editing a beamline setup.

Changes:

  • Set the page size to 9999 to get all detectors by default (the only other place to get detectors is XPDF 'plans', where they specify a beamline name so will not have many detectors returned)
  • Change the detectors query to use subqueries where possible, so it doesn't get too slow
  • Add a listener to the detector 'limits' column, so if the detector is changed, they all change to match

To test:

  • Open the Beamline Parameters page /admin/imaging/param
  • Find a row in the first table that has a Beamline named in the first column
  • Edit the detector, checking there are about 32 possible detectors, and each has a manufacturer and model (some have type in brackets)
  • Check when you change the detector, the 'Limits' column to the right updates automatically
  • Check the change persists after a page refresh
  • Open a XPDF 'Plans' page eg /containers/plan/247898
  • Check the query to list detectors still works ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants