fix: suppress false-positive warnings for default EventFlushIntervalMS and ConfigPollingIntervalMS

[jonathannorris]

Summary

• EventFlushIntervalMS and ConfigPollingIntervalMS are time.Duration fields, so they zero-value to 0 when Options is omitted or partially configured
• CheckDefaults treated 0 as an out-of-range value and emitted a WARN log even though no misconfiguration occurred
• Zero is now handled as "unset" — the default is applied silently; the warning only fires for explicitly-set out-of-range values

Before / After

Before — initializing with no options produces two spurious warnings:

client, err := devcycle.NewClient(sdkKey, &devcycle.Options{})
// WARN: EventFlushIntervalMS cannot be less than 500ms or longer than 1 minute. Defaulting to 30 seconds.
// WARN: ConfigPollingIntervalMS cannot be less than 1 second. Defaulting to 10 seconds.

After — no warnings; defaults are applied silently:

client, err := devcycle.NewClient(sdkKey, &devcycle.Options{})
// (no warnings)

The warning still fires as expected when a value is explicitly set out of range:

client, err := devcycle.NewClient(sdkKey, &devcycle.Options{
    EventFlushIntervalMS: 100 * time.Millisecond, // too low — will warn
})

Notes

Should we also treat passing nil for Options as equivalent to &Options{}? Right now callers have to pass at least an empty struct to avoid a nil pointer — might be worth checking if NewClient guards against that, or if we want to add that convenience.

[Copilot]

Pull request overview

This PR updates Options.CheckDefaults() to treat zero-valued time.Duration option fields as “unset” so defaults are applied without emitting misleading warnings during typical client initialization.

Changes:

• Apply the default EventFlushIntervalMS (30s) silently when the value is 0.
• Apply the default ConfigPollingIntervalMS (10s) silently when the value is 0.
• Preserve warnings (and defaulting) for non-zero values that are out of the allowed range.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.