refactor: flatten nested match for user lookup#6
Open
LudWittg wants to merge 1 commit intoDcodingTheWeb:masterfrom
Open
refactor: flatten nested match for user lookup#6LudWittg wants to merge 1 commit intoDcodingTheWeb:masterfrom
LudWittg wants to merge 1 commit intoDcodingTheWeb:masterfrom
Conversation
TheDcoder
requested changes
Mar 16, 2026
Member
TheDcoder
left a comment
TheDcoder
left a comment
There was a problem hiding this comment.
Good catch, should be good for merge once the indentation is fixed.
Comment on lines
+97
to
+99
| Err(_) => print_error_and_exit("Failed to retrieve target user", 1), | ||
| Ok(None) => print_error_and_exit("Target user does not exist", 1), | ||
| Ok(Some(x)) => x, |
Member
There was a problem hiding this comment.
Incorrect indentation, the whole project uses hard tabs instead of spaces (soft tabs), in hindsight I should've included an .rustfmt.toml file in the root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the nested match for the getpwnam result into a single match block using Ok(Some(x)) and Ok(None). The functionality remains 100% identical. This just improves readability/makes the code more concise.