feat(issue-506): add loadOptions to segmentPlugin#507
Open
sreenath wants to merge 1 commit intoDavidWells:masterfrom
Open
feat(issue-506): add loadOptions to segmentPlugin#507sreenath wants to merge 1 commit intoDavidWells:masterfrom
sreenath wants to merge 1 commit intoDavidWells:masterfrom
Conversation
Author
|
Hey @DavidWells, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to implement #506
Currently, the Segment plugin initialisation does not allow users to pass the optional second argument,
optionsto the coreanalytics.load()function. This limits customisation when loading the Segment library.We request the addition of a new property,
loadOptionswithin the plugin configuration object. This property should accept the desired options object, which will then be passed directly toanalytics.load()alongside thewriteKey.Proposed Implementation Change:
Instead of the current call:
The plugin should be modified to accept and utilize the loadOptions from the plugin configuration: