feat(masonry): add optional adjustHeight prop to prevent layout overlap#918
Open
igenius99-dev wants to merge 1 commit intoDavidHDev:mainfrom
Open
feat(masonry): add optional adjustHeight prop to prevent layout overlap#918igenius99-dev wants to merge 1 commit intoDavidHDev:mainfrom
igenius99-dev wants to merge 1 commit intoDavidHDev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
adjustHeightprop to the Masonry component to allow the container to dynamically match its content height and prevent overlap with subsequent elements.###Problem
The Masonry layout uses absolute positioning, which causes the container to have no intrinsic height. This leads to overlapping content below the component unless height is manually managed.
Solution
adjustHeightprop to enable dynamic height behaviorChanges
Core Component Updates
adjustHeightprop (default:false)Variants Updated
To maintain consistency across the library, the change was applied to all Masonry implementations:
src/content/Components/Masonry/Masonry.jsx(default JS version)src/tailwind/Components/Masonry/Masonry.jsx(Tailwind version)src/ts-default/Components/Masonry/Masonry.tsx(TypeScript version)src/ts-tailwind/Components/Masonry/Masonry.tsx(TypeScript + Tailwind)Supporting Files
src/constants/code/Components/masonryCode.jsupdated to reflect new prop in code previewssrc/demo/Components/MasonryDemo.jsxupdated to demonstrate usagepublic/r/Masonry-*.jsonupdated to sync registry component definitionsNo breaking changes. Existing behavior remains unchanged by default.